[iOS] Network invalidate handlers to cleanup in turbo module mode #41775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 3854735 |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@dmytrorykun merged this pull request in 44d6e43. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…#41775) Summary: We should do some cleanup for handlers in Networking to fix some memory leaks.Ex. `RCTHTTPRequestHandler` hander, `session` retains the handler which leads to leaks. https://github.com/facebook/react-native/blob/385473522cbc525aad08500f5a752dea734c14c3/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.mm#L97 ## Changelog: [IOS] [FIXED] - Network invalidate handlers to cleanup in turbo module mode Pull Request resolved: facebook#41775 Test Plan: Network handlers clean up after invalidating. Reviewed By: NickGerleman Differential Revision: D51846962 Pulled By: dmytrorykun fbshipit-source-id: 17a2875903cda187f2e3ecea46e8f7f3e10d5264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We should do some cleanup for handlers in Networking to fix some memory leaks.Ex.
RCTHTTPRequestHandlerhander,sessionretains the handler which leads to leaks.react-native/packages/react-native/Libraries/Network/RCTHTTPRequestHandler.mm
Line 97 in 3854735
Changelog:
[IOS] [FIXED] - Network invalidate handlers to cleanup in turbo module mode
Test Plan:
Network handlers clean up after invalidating.